Okash Khawaja, on mer. 31 mai 2017 13:55:54 +0100, wrote:
> We should check the flush_buffer method of a tty for null before
> invoking it. Some drivers such as usbserial don't implement
> flush_buffer. This will be required for upcoming patches where we expand
> spk_ttyio to support more than just ttyS*.
>
> Signed-off-by: Okash Khawaja <okash.khawaja@xxxxxxxxx>
Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
>
> ---
> drivers/staging/speakup/spk_ttyio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/drivers/staging/speakup/spk_ttyio.c
> +++ b/drivers/staging/speakup/spk_ttyio.c
> @@ -227,7 +227,8 @@ static unsigned char spk_ttyio_in_nowait
>
> static void spk_ttyio_flush_buffer(void)
> {
> - speakup_tty->ops->flush_buffer(speakup_tty);
> + if (speakup_tty->ops->flush_buffer)
> + speakup_tty->ops->flush_buffer(speakup_tty);
> }
>
> int spk_ttyio_synth_probe(struct spk_synth *synth)
>
--
Samuel
Who wants to remember that escape-x-alt-control-left shift-b puts you into
super-edit-debug-compile mode?
(Discussion in comp.os.linux.misc on the intuitiveness of commands, especially
Emacs.)
_______________________________________________
Speakup mailing list
Speakup@xxxxxxxxxxxxxxxxx
http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup
