Okash Khawaja, on dim. 26 févr. 2017 19:16:35 +0000, wrote: > On Sun, Feb 26, 2017 at 3:27 AM, Samuel Thibault > <samuel.thibault@xxxxxxxxxxxx> wrote: > > So I sent a lot of mails :) > > > > A lot of them are asking to add yet more methods. I'm starting thinking > > that it's tedious to change that in each and every driver, which is kind > > of dumb anyway since it's just the same everywhere. > > > > So I'd say before doing all that stuff, rework what we thought about > > adding methods: instead of adding spk_serial_out directly in struct > > spk_synth > > > > - in spk_types.h, just before struct spk_synth, define > > > > struct spk_io_ops { > > int (*serial_out)(struct spk_synth *synth, const char ch); > > } > > Along the way, thinking of renaming serial_out to synth_out - agnostic > of actual mechanism: serial or ttyio. Indeed :) Samuel _______________________________________________ Speakup mailing list Speakup@xxxxxxxxxxxxxxxxx http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup