On 05.07.21 17:08, Jonathan Corbet wrote:
> Nishanth Menon <nm@xxxxxx> writes:
>
>> Lets drop the unicode characters that peeped in and replace with
>> equivalent utf-8 characters. This makes the CC-BY-4.0 file inline with
>> rest of license files.
>>
>> This messes up code such as scripts/spdxcheck.py which assumed utf-8
>> LICENSE files.
>>
>> Fixes: bc41a7f36469 ("LICENSES: Add the CC-BY-4.0 license")
>
> So...this file *is* in UTF-8; I'm finding your changelog a bit
> confusing.
Ahh, I'm not the only one here.
>> Cc: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>
>> CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> CC: Christoph Hellwig <hch@xxxxxx>
>> Cc: Jonathan Corbet <corbet@xxxxxxx>
>>
>> Reported-by: Rahul T R <r-ravikumar@xxxxxx>
>> Signed-off-by: Nishanth Menon <nm@xxxxxx>
>> ---
>> also see: https://lore.kernel.org/linux-spdx/20210703012128.27946-1-nm@xxxxxx/T/#u
>>
>> LICENSES/dual/CC-BY-4.0 | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/LICENSES/dual/CC-BY-4.0 b/LICENSES/dual/CC-BY-4.0
>> index 45a81b8e4669..869cad3d1643 100644
>> --- a/LICENSES/dual/CC-BY-4.0
>> +++ b/LICENSES/dual/CC-BY-4.0
>> @@ -392,7 +392,7 @@ Section 8 -- Interpretation.
>> Creative Commons is not a party to its public
>> licenses. Notwithstanding, Creative Commons may elect to apply one of
>> its public licenses to material it publishes and in those instances
>> -will be considered the “Licensor.” The text of the Creative Commons
>> +will be considered the "Licensor." The text of the Creative Commons
FWIW, I kinda like that the text (apart from the intro) up to now is
identical to the official license text (where I copied it from iirc when
I added it), but well, the type of quotes really shouldn't matter, so:
Acked-by: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>
> It seems that what you're really doing is replacing "smart quotes" with
> the basic ASCII variety? That seems like a fine thing to do, but that's
> not really what the changelog says.
Thx for handling this, Jon.
> [...]
Ciao, Thorsten
