On Mon, Aug 31, 2020 at 07:45:25AM +0200, Lukas Bulwahn wrote:
>
>
> On Sun, 30 Aug 2020, Andrew Morton wrote:
>
> > On Thu, 27 Aug 2020 14:54:05 +0530 Mrinal Pandey <mrinalmni@xxxxxxxxx> wrote:
> >
> > > commit b72231eb7084 ("scripts: add spdxcheck.py self test") added the file
> > > spdxcheck-test.sh to the repository without the executable flag and license
> > > information.
> >
> > The x bit shouldn't matter.
> >
> > If someone downloads and applies patch-5.9.xz (which is a supported way
> > of obtaining a kernel) then patch(1) will erase the x bit anyway.
> >
>
> Andrew, Kees,
>
> thanks for the feedback.
>
> As his mentor, I see two valuable tasks for Mrinal to work on:
>
> 1. Document this knowledge how scripts should be called, not relying on
> the executable bit, probably best somewhere here:
> ./Documentation/kbuild/makefiles.rst, a new section on using dedicated
> scripts in chapter 3 ("The kbuild files").
>
> https://www.kernel.org/doc/html/latest/kbuild/makefiles.html#the-kbuild-files
Yes, that would be excellent.
> 2. Determine if there are places in the build Makefiles that do rely on
> the executable bit and fix those script invocations. (Kees' idea of remove
> all executable bits and see...)
I think this has value, yes. I don't think patches to remove the x bits
are needed, but any cases where they are depended on need to be fixed.
And I think "3" could be "wire up or remove spdx shell script"
--
Kees Cook
