On Fri, May 31, 2019 at 09:40:26AM +0900, Masahiro Yamada wrote: > On Fri, May 31, 2019 at 3:31 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Thu, May 30, 2019 at 07:01:01AM -0500, Kate Stewart wrote: > > > On Thu, May 30, 2019 at 6:53 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > On Thu, May 30, 2019 at 05:58:05PM +0900, Masahiro Yamada wrote: > > > > > Hi. > > > > > > > > > > > > > > > Recently, "Makefiles", "Kconfig" files were given with SPDX License tags. > > > > > > > > > > Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > > > > Date: Sun May 19 13:07:45 2019 +0100 > > > > > > > > > > treewide: Add SPDX license identifier - Makefile/Kconfig > > > > > > > > > > > > > > > > > > > > > > > > > But, the file name "Kbuild" is also a Makefile. > > > > > > > > > > Conventionally, Linux build system uses both "Kbuild" and "Makefile". > > > > > > > > > > > > > > > For example, SPDX tag is missing in > > > > > > > > > > arch/x86/Kbuild > > > > > arch/x86/include/uapi/asm/Kbuild > > > > > arch/x86/include/asm/Kbuild > > > > > > > > > > > > > > > Will somebody work on "Kbuild" files please ? > > > > > > > > Sure, how about the attached patch, any objection to me queueing it up? > > > > > > Thanks Greg. > > > > > > Thomas' initial patch fixed a bunch of these in the initial cleanup, > > > but I guess > > > more were added (and overlooked since then). > > > > > > Reviewed-by: Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx> > > > > Thanks for the review, I'll queue this up with the next round of patches > > from Thomas to go to Linus. > > Thanks. > > > > Bikeshed: > > Commit ec8f24b7faaf3d4799a7c3f4c1b87f6b02778ad1 > used "GPL-2.0-only". > > So, I prefer avoiding the deprecated "GPL-2.0". I know, but I like that version better, the whole "-only" thing I consider crazy and nonsense :) > We have been discussing here: > https://lkml.org/lkml/2019/5/30/1575 Both versions are just fine to use in the kernel at this point in time. As this only touches 100 or so files, it's not a big deal, we have much bigger issues to worry about here. thnaks, greg k-h
