Greg, On Tue, 7 May 2019, Greg KH wrote: > > Anyway, glad to help out if you want me to. Running the scripts is one thing. The more important thing is to figure out how we are going to review these patches and agree that the conclusion is correct. Ideally we have lots of Reviewed-by's on each of them. Yes, it's 500+ and some of them are really large, but the point is that at least in my opinion it's enough to carefully review the 'normalized' patterns which are in the change log. I have some postprocessing checks (not yet in utils) which verify that author/copyright notices which are in the middle of the removed crap are preserved. The other issue which I worked on yesterday night (krobot finding a few corner cases where the patcher did not handle some odd comment formatting correctly) should be gone. I just started a new full run to verify that. Apropos changelog. You said they need some care. If you check out the utils repo, there are templates in the step2/3 directories and the subdirectories of step1. If you could work on them that would be appreciated. Thanks, tglx
