On Fri. 6 Dec. 2024 at 00:52, Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> wrote: > On Thu. 5 Dec. 2024 at 03:54, David Laight <David.Laight@xxxxxxxxxx> wrote: > > From: Vincent Mailhol > > > Sent: 02 December 2024 17:33 > > > > > > In __clamp_once(), > > > > > > __builtin_choose_expr(__is_constexpr((lo) > (hi)), (lo) <= (hi), true) > > > > > > is equivalent to: > > > > > > !is_const_false((lo) <= (hi)) > > > > > > Apply is_const_false() to simplify __clamp_once(). > > > > There is already a patch 'for next' that changes it use BUILD_BUG_ON_MSG() > > and statically_true(). > > Found it! > > https://lore.kernel.org/all/34d53778977747f19cce2abb287bb3e6@xxxxxxxxxxxxxxxx/ I picked up your patch and got two build errors on an allyesconfig. You already sent a patch for the first one: https://lore.kernel.org/all/33893212b1cc4a418cec09aeeed0a9fc@xxxxxxxxxxxxxxxx/ For the second one, I submitted a patch here: https://lore.kernel.org/all/20241209-nfs4state_fix-v1-1-7a66819c60f0@xxxxxxxxxx/ I will wait for those two to appear in Andrew's mm tree first, and only then, I will send a v2 (that will be rebased on the mm tree to get your change). Meanwhile, I think this series will be on hiatus. Yours sincerely, Vincent Mailhol
