On Wed, Sep 04, 2024 at 11:21:45AM +0200, Uwe Kleine-König wrote:
> Hello Dan,
>
> On 9/4/24 07:39, Dan Carpenter wrote:
> > On Fri, May 24, 2024 at 10:47:23AM +0800, wuruilong wrote:
> > > +const struct target target_loongarch64 = {
> > > + .mach = MACH_LOONGARCH64,
> > > + .bitness = ARCH_LP64,
> > > +
> > > + .big_endian = 0,
> >
> > No need to initialize things to zero.
>
> While your concern is technically correct, mentioning it explicitly for a
> human reader is still nice IMHO.
The only reason I mentioned any of this is because the unsigned_char thing is
probably a bug. Otherwise, I don't go around nit-picking these types of things.
I don't have strong feelings about this.
regards,
dan carpenter
