On Sun, Jun 26, 2022 at 03:42:30PM +0100, Ramsay Jones wrote: > > > On 26/06/2022 14:07, Luc Van Oostenryck wrote: > > From: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> > > > > When inlining a variadic function (unsupported in general by > > sparse but OK when the arguments are unused and occurs as such > > in the kernel), the extra arguments are added in the declaration > > list as SYM_NODE. > > > > But these arguments can already be SYM_NODEs. Sparse doesn't > > support everywhere such nested nodes (they must be merged) but > > in this case it's fine as the node will be merged when evaluated. > > > > Add a comment telling the situation is fine. > > Also, move the code to where the variadic arguments are handled > > since the fixed one will be anyway directly overwritten. > > > > Note: Sparse doesn't really support inlining of variadic functions > > but is fine when the arguments are not used (and such cases > > occur in the kernel). > > This note prompted a feeling of deja-vu :) It is simply repeating > (in slightly different words) the content of the first paragraph. Hehe, indeed. I'm really bad at rereading myself. Thanks for noticing. -- Luc
