On Tue, Jan 25, 2022 at 4:59 PM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > On Tue, Jan 25, 2022 at 3:34 PM Segher Boessenkool > <segher@xxxxxxxxxxxxxxxxxxx> wrote: > > > > Hi! > > > > On Mon, Jan 24, 2022 at 03:26:36PM -0800, Nick Desaulniers wrote: > > > > > If this is fixed in gcc-10, then we can probably add a comment with a > > > FIXME link to the issue or commit to replace __COUNTER__ with %= one > > > day. If not, then we can probably come up with a reduced test case > > > for the GCC devs to take a look at, then add the FIXME comment to > > > kernel sources. > > > > Please open a PR? > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104236 Andrew clarified (thanks Andrew!) that %= can't be used as I imagined https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104236#c4 and that I think was alluded to in commit 3d1e236022cc ("objtool: Prevent GCC from merging annotate_unreachable()") which is fine, so I'll just need to keep usage of __COUNTER__. I'll try out a revised approach for this patch tomorrow. -- Thanks, ~Nick Desaulniers
