Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > Yeah. It finds it. :) It works pretty well. The temptation is to > ignore left shifts. Otherwise I think I will just push this. Great, glad to hear! I didn't check everything but these ones look like real bugs (samples but still): > samples/kfifo/bytestream-example.c:126 fifo_write() warn: check sign expansion for 'ret' > samples/kfifo/bytestream-example.c:142 fifo_read() warn: check sign expansion for 'ret' > samples/kfifo/record-example.c:133 fifo_write() warn: check sign expansion for 'ret' > samples/kfifo/record-example.c:149 fifo_read() warn: check sign expansion for 'ret' > samples/kfifo/inttype-example.c:119 fifo_write() warn: check sign expansion for 'ret' > samples/kfifo/inttype-example.c:135 fifo_read() warn: check sign expansion for 'ret' Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
