In rewrite_load_instruction(), when testing if all phi-sources are the same, the candidate is given an identifier if it hasn't one already. But doing this inside this loop is strange: * the pseudo may, at the end, not be selected but is changed anyway * the identifier should be given either when the phi-source is created or at the end of the loop if selected. So, do not change the identifier inside the selection loop. Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> --- memops.c | 1 - 1 file changed, 1 deletion(-) diff --git a/memops.c b/memops.c index 5386c5a1f416..119a39a180d5 100644 --- a/memops.c +++ b/memops.c @@ -29,7 +29,6 @@ static void rewrite_load_instruction(struct instruction *insn, struct pseudo_lis FOR_EACH_PTR(dominators, phi) { if (new != phi->def->phi_src) goto complex_phi; - new->ident = new->ident ? : phi->ident; } END_FOR_EACH_PTR(phi); /* -- 2.31.0