On Fri, Feb 26, 2021 at 11:56:58PM +0000, Ramsay Jones wrote: > On 25/02/2021 23:39, Luc Van Oostenryck wrote: > > diff --git a/liveness.c b/liveness.c > > index 30a9a5b6b169..755509e59b52 100644 > > --- a/liveness.c > > +++ b/liveness.c > > @@ -76,6 +76,7 @@ static void track_instruction_usage(struct basic_block *bb, struct instruction * > > /* Uni */ > > case OP_UNOP ... OP_UNOP_END: > > case OP_SYMADDR: > > + case OP_SLICE: > > USES(src1); DEFINES(target); > > wouldn't USES(src) be more appropriate? They are not binops. Yes, even though they are synonymous (and documented as such) it makes thinks slightly clearer. I'll change this in a separate patch. Thank you (also for the 2 other patches), -- Luc
