On 01/14/2021 01:14 AM, Yonghong Song wrote:
I do not think this fix is correct. x86 does not define its own
rwonce.h and still compiles fine.
As noted in the above, we have include/asm-generic/rwonce.h.
Once you do a proper build, you will have rwonce.h in arch
generated directory like
-bash-4.4$ find . -name rwonce.h
./include/asm-generic/rwonce.h
./arch/alpha/include/asm/rwonce.h
./arch/arm64/include/asm/rwonce.h
./arch/x86/include/generated/asm/rwonce.h
for mips, it should generated in
arch/mips/include/generated/asm/rwonce.h. Please double check why this
does not happen.
Hi Yonghong,
Thank you very much for your reply.
You are right, this patch is meaningless.
I find this build error when make M=samples/bpf after make clean,
so the ./arch/mips/include/generated/asm/rwonce.h is not exist.
After rebuild the kernel, this header file can be found when make
M=samples/bpf due to samples/bpf/Makefile contains $LINUXINCLUDE.
$ find . -name rwonce.h
./include/asm-generic/rwonce.h
./arch/arm64/include/asm/rwonce.h
./arch/mips/include/generated/asm/rwonce.h
./arch/alpha/include/asm/rwonce.h
$ cat ./arch/mips/include/generated/asm/rwonce.h
#include <asm-generic/rwonce.h>
Hi Sergei and kernel test robot,
Thank you for your suggestion and report,
please ignore this patch, sorry for the noise.
Thanks,
Tiezhu