On Mon, Dec 28, 2020 at 05:18:50PM +0000, Ramsay Jones wrote:
>
>
> On 26/12/2020 17:51, Luc Van Oostenryck wrote:
> > During parsing, Sparse recognizes the attribute 'packed' but this
> > attribute is otherwise ignored for several reasons:
> > 1) the attribute in 'struct __attr { ... }' is wrongly handled as
> > belonging to the whole declaration but it should belong to the type,
> > 2) the attribute in 'struct <name> { ... } __attr;' is simply ignored,
> > 3) the layout of packed bitfields need special care.
> >
> > This series contains 2 parts:
> > 1) handling of type attributes
> > 2) correct layout of packed structs, including packed bitfields.
> >
> >
> > This series is also available for review and testing at:
> > git://git.kernel.org/pub/scm/devel/sparse/sparse-dev.git packed-v2
>
> I left a couple of minor comments, but (apart from patch #16) this
> otherwise LGTM.
>
> Patch #16 also looks good, but I would need to study it a bit more
> than I have time available to be totally happy. It does not seem
> to be handling the 'lowering' of 'odd bit-sized' symbols created in
> the previous patch (to answer my own question), so I would have to
> apply the patches (or fetch the above branch) to study some more.
Well, patch #16 doesn't contain the lowering, it kinda just enables
the last bits to support (without out-of-bound access) packed structures
including packed bitfields.
> Hope you had a good holiday.
Thank you. In truth, it was strange and quiet, very quiet.
I wish you all the best for 2021!
-- Luc
