On Mon, Nov 16, 2020 at 2:30 PM Luc Van Oostenryck
<luc.vanoostenryck@xxxxxxxxx> wrote:
>
> +static void adjust_phisrc(struct basic_block *top, struct instruction *insn)
My only issue is that this is a really odd name, and calling convention.
"adjust"?
Wouldn't it be more sensible to call this "remove_phisrc()", because
that's what it does. It removes the matching phisrc instruction in the
specified basic block.
(I also think it might be a bit more obvious to do the get_phinode()
in the caller, and simply pass in the OP_PHI instruction, but maybe
you had reasons to do it that way).
Linus
