On Mon, Oct 26, 2020 at 10:41:36AM -0700, Linus Torvalds wrote:
> On Sun, Oct 25, 2020 at 9:53 PM Luc Van Oostenryck
> <luc.vanoostenryck@xxxxxxxxx> wrote:
> >
> > This occurs currently on v5.10-rc1 because of some ifdefery.
>
> Well, sparse being more robust is good, so the patch looks sane to me..
>
> But can you point to the actual 5.10-rc1 problem? I haven't seen the
> report, and afaik gcc will complain about this too ("label at end of
> compound statement") so I'm surprised sparse hits it..
Well, I was surprised it wasn't caught and was ready to send a patch
but it can only happen when using sparse, see below, quite ironical:
drivers/scsi/qla2xxx/qla_tmpl.c:1052.
1050 }
1051
1052 bailout:
1053 #ifndef __CHECKER__
1054 if (!hardware_locked)
1055 spin_unlock_irqrestore(&vha->hw->hardware_lock, flags);
1056 #endif
1057 }
-- Luc
