On 06/09/2020 13:40, Luc Van Oostenryck wrote:
> Add a few testcases showing the effectiveness of these
> simplifications and to catch possible future regressions.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
> ---
> validation/optim/and-lsr-or-shl0.c | 12 ++++++++++++
> validation/optim/and-lsr-or-shl1.c | 12 ++++++++++++
> validation/optim/and-shl-or-lsr0.c | 13 +++++++++++++
> validation/optim/lsr-or-lsr0.c | 20 ++++++++++++++++++++
> validation/optim/trunc-or-shl0.c | 19 +++++++++++++++++++
> 5 files changed, 76 insertions(+)
> create mode 100644 validation/optim/and-lsr-or-shl0.c
> create mode 100644 validation/optim/and-lsr-or-shl1.c
> create mode 100644 validation/optim/and-shl-or-lsr0.c
> create mode 100644 validation/optim/lsr-or-lsr0.c
> create mode 100644 validation/optim/trunc-or-shl0.c
Given that these are new tests, I was (er..) expecting some
'*.expected' files! However, I guess (since they are all failing
tests anyway) those will come in future patches which will
actually implement the optimization.
>
> diff --git a/validation/optim/and-lsr-or-shl0.c b/validation/optim/and-lsr-or-shl0.c
> new file mode 100644
> index 000000000000..e2a517ab65c4
> --- /dev/null
> +++ b/validation/optim/and-lsr-or-shl0.c
> @@ -0,0 +1,12 @@
> +unsigned int and_lsr_or_shl0(unsigned int a, unsigned int b)
> +{
> + return ((a | b << 12) >> 12) & 0xfff00000;
> +}
> +
> +/*
> + * check-name: and-lsr-or-shl0
> + * check-command: test-linearize -Wno-decl $file
> + * check-known-to-fail
> + *
> + * check-output-excludes: shl\\.
> + */
> diff --git a/validation/optim/and-lsr-or-shl1.c b/validation/optim/and-lsr-or-shl1.c
> new file mode 100644
> index 000000000000..6f2d05a0bfdd
> --- /dev/null
> +++ b/validation/optim/and-lsr-or-shl1.c
> @@ -0,0 +1,12 @@
> +unsigned int and_lsr_or_shl1(unsigned int a, unsigned int b)
> +{
> + return ((a | b << 12) >> 12) & 0x000fffff;
> +}
> +
> +/*
> + * check-name: and-lsr-or-shl1
> + * check-command: test-linearize -Wno-decl $file
> + * check-known-to-fail
> + *
> + * check-output-excludes: shl\\.
> + */
> diff --git a/validation/optim/and-shl-or-lsr0.c b/validation/optim/and-shl-or-lsr0.c
> new file mode 100644
> index 000000000000..f2a7cc631258
> --- /dev/null
> +++ b/validation/optim/and-shl-or-lsr0.c
> @@ -0,0 +1,13 @@
> +unsigned and_shl_or_lsr0(unsigned a, unsigned b)
> +{
> + return ((a | (b >> 12)) << 12) & 0xfff00000;
> +}
> +
> +/*
> + * check-name: and-shl-or-lsr0
> + * check-command: test-linearize -Wno-decl $file
> + * check-known-to-fail
> + *
> + * check-output-ignore
> + * check-output-excludes: or\\.
> + */
> diff --git a/validation/optim/lsr-or-lsr0.c b/validation/optim/lsr-or-lsr0.c
> new file mode 100644
> index 000000000000..a1687ec21ff0
> --- /dev/null
> +++ b/validation/optim/lsr-or-lsr0.c
> @@ -0,0 +1,20 @@
> +#define S 12
> +
> +// ((x >> S') | y) >> S;
> +// -> ((x >> S >> S) | (y >> S)
// -> (x >> S' >> S) | (y >> S)
// -> (x >> (32 - S + S)) | (y >> S)
// -> (x >> 32) | (y >> S)
// -> (0) | (y >> S)
// -> y >> S
> +
> +int lsr_or_lsr0(unsigned int x, unsigned int b)
> +{
> + return ((x >> (32 - S)) | b) >> S;
> +}
> +
> +/*
> + * check-name: lsr-or-lsr0
> + * check-command: test-linearize -Wno-decl $file
> + * check-known-to-fail
> + *
> + * check-output-ignore
> + * check-output-pattern(1): lsr\\.
> + * check-output-excludes: and\\.
> + * check-output-excludes: or\\.
> + */
> diff --git a/validation/optim/trunc-or-shl0.c b/validation/optim/trunc-or-shl0.c
> new file mode 100644
> index 000000000000..4d85a6bd4ec4
> --- /dev/null
> +++ b/validation/optim/trunc-or-shl0.c
> @@ -0,0 +1,19 @@
> +char trunc_or_shl0a(unsigned a, unsigned b)
> +{
> + return (a << 8) | b;
> +}
> +
> +char trunc_or_shl0b(unsigned a, unsigned b)
> +{
> + return a | (b << 8);
> +}
> +
> +/*
> + * check-name: trunc-or-shl0
> + * check-command: test-linearize -Wno-decl $file
> + * check-known-to-fail
> + *
> + * check-output-ignore
> + * check-output-excludes: or\\.
> + * check-output-excludes: shl\\.
Hmm, I can't see an optimization for these two! :(
Care to explain just what you expect? (maybe with an
'*.expected' file?)
> + */
>
ATB,
Ramsay Jones
