On Sat, Aug 15, 2020 at 06:59:49PM +0900, Stafford Horne wrote: > On Thu, Aug 06, 2020 at 09:29:59PM +0200, Luc Van Oostenryck wrote: > > Sparse warns shifts by a negative or oversized amount but > > it does this even on code that will not be executed. It's > > annoying because such warnings are given for generic macros. > > > > The strategy for these warnings is changed in patch 4: > > they are delayed until after the elimination of deadcode. > > This uncovered a bug in the type evaluation and the linearization > > of shift-assigns which is now solved in patch 2 & 3. > > > > Thanks to Stafford Horne to bring this back to my attention. > > > > This series is available for testing & review at: > > git://git.kernel.org/pub/scm/devel/sparse/sparse.git bad-shift-equal > > Thanks! > > I see you merged this already, I tested it and see no regressions on my kernel > build, and confirm the xchg issues are fixed. > > Sorry, I reviewed this early but didn't respond until now as I had time to test. I should have waited a little more before merging (but OTOH, I thought, it would be easier for you to give it a try before sending your PR to Linus if already merged). -- Luc
