Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > In this CIFS case, the leak is on the success path (as well as the > failure path) so my theory would be that it would be caught in testing > and will only cause false positives for static analysis. I can't see > any automated way to know which success paths should take a reference > and which should not. Ah, I see. I guess with extra annotations and more sophisticated analysis we could have something but it seems out of scope. Anyway, thanks for looking into it. Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)