On Fri, Jun 12, 2020 at 01:56:20AM +0100, Ramsay Jones wrote:
> On 10/06/2020 21:27, Luc Van Oostenryck wrote:
> >
> > A table is table is preferable but a complication for doing this
>
> s/table is table is/table is/
Thanks for noticing this typo (and the ones in the other patches).
> > +static void declare_one_builtin(const struct builtin_fn *entry)
> > +{
> > + struct symbol *sym = create_symbol(0, entry->name, SYM_NODE, NS_SYMBOL);
>
> So, assuming stream 0 here as well ...
>
> > -static void declare_builtin(const char *name, struct symbol *rtype, int variadic, ...)
> > -{
> > - int stream = 0; // FIXME
>
> ... and, yes, here is the FIXME (so my memory is not as bad
> as I thought!).
>
> This all looks good.
Well yes ... I don't really like the situation, though.
I probably should do something like adding a #define builtin_stream 0
and use this.
Thnaks to bring my attention to this.
-- Luc
