On Fri, Feb 14, 2020 at 12:33:20PM +0100, Oleg Nesterov wrote: > With this change dissect can know the scope of SYM_STRUCT/UNION/ENUM, > see the next patch. > > Note that MOD_TOPLEVEL can be set even if struct/union/enum type is > private and bind_symbol() is not called. I don't like that very much. For example: why this is needed for struct/union/enum and not other types? Should it be possible to use the function toplevel() or add and helper for it in scope.c? > IIUC nobody else looks at SYM_STRUCT->ctype.modifiers, "make check" > doesn't show any difference. Yes, it's true and it shouldn't make any difference but still I would prefer to not mix symbols and types more than they already are. -- Luc
