On Mon, Jan 20, 2020 at 02:38:24AM -0800, john.levon@xxxxxxxxxx wrote: > From: Toomas Soome <tsoome@xxxxxx> > > The SPARCV9 compile check needs to look for __sparcv9 on some systems, > and should also define "sparc". Hi. Thanks for the patch. Is it possible to have Toomas' Signed-off-by for this patch? No need to resend the patch, just a reply to this email saying it's OK is enough. > case MACH_SPARC32: > predefine("__sparc__", 1, "1"); > predefine("__sparc", 1, "1"); > + predefine("sparc", 1, "1"); I'm wondering if there is a real need for this one or if it's just to reflect what GCC do? I'm a bit reluctant to add it since it lies in the user's namespace. But I'm fine to add it if there is a real use case for it (in which case I'll just slightly change the patch to not predefine it if one of the ISO dialect is selected (via --std=c99, ...)). -- Luc