On Mon, Nov 04, 2019 at 10:46:44PM +0100, Luc Van Oostenryck wrote: > On Fri, Nov 01, 2019 at 04:36:51PM +0000, Ben Dooks wrote: > > I've put the latest code up at: > > > > https://github.com/bjdooks-ct/sparse bjdooks/printf20 > > > > I think it has all the issues dealt with. > > > > I can't currently post or do a final test as away from work laptop. > > Thank you. > > I've a few more remarks about formatting or naming and > also some simplifications I would like you make. 'struct format' is a bit too generic. Rename it. >From 07bd6a35ce437617b8c0d2bc32273bcd9dfd84a0 Mon Sep 17 00:00:00 2001 From: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> Date: Mon, 4 Nov 2019 21:44:54 +0100 Subject: [PATCH 3/7] s/struct format/struct attr_format/ --- symbol.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/symbol.h b/symbol.h index 5bfaac588..228c3a392 100644 --- a/symbol.h +++ b/symbol.h @@ -98,7 +98,7 @@ extern struct context *alloc_context(void); DECLARE_PTR_LIST(context_list, struct context); -struct format { +struct attr_format { unsigned short index; /* index in argument list for format string */ unsigned short first; /* where first variadic argument is */ }; @@ -109,7 +109,7 @@ struct ctype { struct context_list *contexts; struct ident *as; struct symbol *base_type; - struct format format; + struct attr_format format; }; struct decl_state { -- 2.23.0
