On Tue, Oct 22, 2019 at 11:31:27AM +0100, Ben Dooks wrote: > > I might spend some time fixing those up... there's plenty of warning > fixes to go through. > > I've not yet run my test on a current kernel, but printf type seems > to be one place where people have been a bit sloppy. With the changes I sent you and using check_assignment_types() for printf_fmt_numtype() I get only 3 warnings in the same drivers, all for trying to print a bitwise type (which should probably be acceptable for the %x format). But yes, checking the signedness will most probably gives a lot of warnings. I think this shouldn't be done without support for the flag '-Wformat-signedness'. -- Luc