On Tue, Oct 08, 2019 at 04:12:28PM +0200, Vegard Nossum wrote:
> Hi,
>
> The "graph" binary segfaults on this input:
>
> asm("");
>
> This is what gdb says:
>
> (gdb) run
> Starting program: /home/vegard/git/sparse/graph asm.c
> digraph call_graph {
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x0000000000401505 in graph_ep (ep=0x7ffff7f62010) at graph.c:52
> 52 sname = stream_name(ep->entry->bb->pos.stream);
> (gdb) bt
> #0 0x0000000000401505 in graph_ep (ep=0x7ffff7f62010) at graph.c:52
> #1 main (argc=<optimized out>, argv=<optimized out>) at graph.c:191
> (gdb) p ep->entry
> $1 = (struct instruction *) 0x0
>
> I've attached a tentative patch that fixes my segfault, but maybe this
> is not the correct solution or maybe other binaries are impacted.
Hi,
Thank you a lot for investigating this.
Yes, most others binaries also need some supplementary checks. At first
I did the same obvious change as you did but I think I'll finally do
a partial revert of the offending commit. I'll look at it this evening.
Best regards,
-- Luc
