Re: [PATCH] void-cond: allow void in conditional expression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 02, 2019 at 02:45:01PM -0700, Randy Dunlap wrote:
> On 10/2/19 2:23 PM, Luc Van Oostenryck wrote:
> > As an extension, allow conditional expressions (?:) with one
> > side of type 'void' and consider the result to also be void.
> > 
> > The warning can be reinstated with the flag '-Wcond-void'.
> > 
> > Note: I only see a single occurrence of this in the kernel.
> 
> Yes, I would prefer to eliminate that one.  :)
> 
> > Suggested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> 
> I prefer
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> 
> I didn't try to Suggest this.

Yes, true indeed.
 
> One man page edit below...
> 
> > +.B \-Wconditional\-void
> > +Warn if one side of a conditional expression (\fB? :\fR) is of type
> > +void and the other one not.
> > +As an extension, Sparse consider the result of such expressions as also
> 
>                            considers

Fixed.

Thanks,
-- Luc 



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux