On Thu, Apr 04, 2019 at 12:20:06PM +0100, Ben Dooks wrote: > On 03/04/2019 23:24, Luc Van Oostenryck wrote: > > On Wed, Apr 03, 2019 at 04:35:46PM +0100, Ben Dooks wrote: > > > This is an updated series against the latest sparse development > > > of the code to deal with printf va-arg format checking. I've fixed > > > a few issues and would like to get a review to see if there is > > > anything that still needs to be looked at. > > > > Things are looking quite good. > > I've sent some remarks but all of them are quite minor. > > I'll look at it a bit deeper and at the tests in the next few days. > > Great, thanks for looking. > I have gone through and sorted most of it out this morning. > I can re-post a new version later. Nice. You can already post them or wait until I've fully reviewed the series, as you prefer. There is another thing I forgot to ask you yesterday: before the series is merged I would like you change the blocks comments: /* line 1 * line 2 */ into (the more usual style used in sparse): /* * line 1 * line 2 */ or (even better): // line 1 // line 2 Best regards, -- Luc
