On Wed, Apr 03, 2019 at 04:35:52PM +0100, Ben Dooks wrote: > From: Ben Dooks <ben-linux@xxxxxxxxx> > > The original update to evaluate.c did the va-arg checking > before the standard checks. This is due to degernate() > removing expr->string so save the string before the loop > and then use it afterwards. > > -> to push back into evaluate.c if no other options available. I think this patch is by far the best thing to do. Even without this ordering problem, get_printf_fmt() is a good thing. I just think it would be better to keep the whole sym->initializer (so you will have an EXPR_STRING with its 'wide' indicator). -- Luc
