On 20/02/2019 21:12, Luc Van Oostenryck wrote:
> On Wed, Feb 20, 2019 at 05:17:29PM +0100, Uwe Kleine-König wrote:
>> On 2/20/19 12:25 PM, Luc Van Oostenryck wrote:
>>> On Wed, Feb 20, 2019 at 01:50:21AM +0000, Ramsay Jones wrote:
>>>>
>>>>
>>>> On 17/02/2019 15:31, Luc Van Oostenryck wrote:
>>>>> From: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>
>>>>>
>>>>> `uname -m` returns information about the host machine but this
>>>>> information is useless when cgcc is used with a non-native compiler.
>>>>> In this case it's information about the target machine that is needed.
>>>>>
>>>>> [This can happen when cross compiling or (more
>>>>> common) if you are running a 32 bit userspace on a 64 bit kernel. The
>>>>> latter makes sparse fail to build on some machines of the Debian build
>>>>> farm as for example some armhf builder run on arm64 kernels.]
>>>>>> This patch is only lightly tested and also misses details for mips* and
>>>>
>>>> missing [ and ...
>>>>> so marked as RFC.]
>>>>
>>>> probably should be removed completely, since it is no longer
>>>> an RFC?
>>>
>>> I still consider it more or less as RFC since it's lack some testing.
>>> And since it started from Uwe's patch for Debian builds, I would
>>> prefer to hear his opinion about it first.
>>
>> Do you have this in a branch somewhere to pull? Then I can give it a go
>> on a few Debian porter machines.
>
> That would be wonderful. I've put the branch at:
> git://git.kernel.org/pub/scm/devel/sparse/sparse-dev.git cgcc-dumpmachine-v2
>
> It's the same as the patches posted here but:
> *) with the last 2 patches removed
> *) with Ramsay's comments taken in account
> *) rebased on top of the current master.
BTW, I think commit 1a51714958 ("teach sparse about -mfloat-abi on ARM",
2019-02-17) is incorrect. It seems to me to have (despite the commit
title) implemented '-ffloat-abi' _not_ '-mfloat-abi'. This makes some
later commits ineffective as well, because sparse does not complain
when passed '-mfloat-abi=hard' (or indeed '-ffloat-abi=junk').
ATB,
Ramsay Jones
