On 20/02/2019 11:25, Luc Van Oostenryck wrote: > On Wed, Feb 20, 2019 at 01:50:21AM +0000, Ramsay Jones wrote: >> >> >> On 17/02/2019 15:31, Luc Van Oostenryck wrote: >>> From: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx> >>> >>> `uname -m` returns information about the host machine but this >>> information is useless when cgcc is used with a non-native compiler. >>> In this case it's information about the target machine that is needed. >>> >>> [This can happen when cross compiling or (more >>> common) if you are running a 32 bit userspace on a 64 bit kernel. The >>> latter makes sparse fail to build on some machines of the Debian build >>> farm as for example some armhf builder run on arm64 kernels.] >>>> This patch is only lightly tested and also misses details for mips* and >> >> missing [ and ... >>> so marked as RFC.] >> >> probably should be removed completely, since it is no longer >> an RFC? > > I still consider it more or less as RFC since it's lack some testing. > And since it started from Uwe's patch for Debian builds, I would > prefer to hear his opinion about it first. Ah, OK, fair enough. ;-) [BTW, I am used to seeing RFC in the PATCH header rather than in the commit message - it makes the transition from RFC to non-RFC easier, since you don't have to edit the commit! :-D ] ATB, Ramsay Jones
