Re: [PATCH] validation: Add patterns FAIL, PASS, XPASS and XFAIL to test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 31, 2019 at 10:23:44AM +0100, Uwe Kleine-König wrote:
> On 1/31/19 9:49 AM, Uwe Kleine-König wrote:
> > This simplifies finding the offending test when the build ended with
> > 
> > 	KO: out of 584 tests, 527 passed, 57 failed
> > 		56 of them are known to fail
> > 
> > Signed-off-by: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>
> > ---
> >  validation/test-suite | 11 +++++++++--
> >  1 file changed, 9 insertions(+), 2 deletions(-)
> > 
> > diff --git a/validation/test-suite b/validation/test-suite
> > index f79a9023d95a..a5572d5e6965 100755
> > --- a/validation/test-suite
> > +++ b/validation/test-suite
> > @@ -403,9 +403,16 @@ do_test()
> >  	if [ "$must_fail" -eq "1" ]; then
> >  		if [ "$test_failed" -eq "1" ]; then
> >  			[ -z "$vquiet" ] && \
> > -			echo "info: test '$file' is known to fail"
> > +			echo "info: XFAIL: test '$file' is known to fail"
> >  		else
> > -			echo "error: test '$file' is known to fail but succeed!"
> > +			echo "error: XPASS: test '$file' is known to fail but succeed!"
> > +		fi
> > +	else
> > +		if [ "$test_failed" -eq "1" ]; then
> > +			echo "error: FAIL: test '$file' is failed"
> 
> When reading my own patch after it returned to me in my sparse folder I
> noticed a fault here. We want the "is" dropped in the above line. Should
> I resend for that?

No no, a resend is not needed at all, I've directly changed it.
 
-- Luc



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux