On Tue, Sep 18, 2018 at 9:30 AM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Sep 17, 2018 at 08:19:50PM -0700, Stefan Agner wrote: >> On 13.09.2018 16:59, Miguel Ojeda wrote: >> > The naked attribute is supported by at least gcc >= 4.6 (for ARM, >> > which is the only current user), gcc >= 8 (for x86), clang >= 3.1 >> > and icc >= 13. See https://godbolt.org/z/350Dyc >> > >> > Therefore, move it out of compiler-gcc.h so that the definition >> > is shared by all compilers. >> > >> > This also fixes Clang support for ARM32 --- 815f0ddb346c >> > ("include/linux/compiler*.h: make compiler-*.h mutually exclusive"). >> > >> > Cc: Stefan Agner <stefan@xxxxxxxx> >> > Cc: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> >> > Cc: Eli Friedman <efriedma@xxxxxxxxxxxxxx> >> > Cc: Christopher Li <sparse@xxxxxxxxxxx> >> > Cc: Kees Cook <keescook@xxxxxxxxxxxx> >> > Cc: Ingo Molnar <mingo@xxxxxxxxxx> >> > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> >> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> > Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> >> > Cc: Joe Perches <joe@xxxxxxxxxxx> >> > Cc: Dominique Martinet <asmadeus@xxxxxxxxxxxxx> >> > Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> >> > Cc: linux-sparse@xxxxxxxxxxxxxxx >> > Suggested-by: Arnd Bergmann <arnd@xxxxxxxx> >> > Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> >> > Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> >> > Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> >> >> Reviewed-by: Stefan Agner <stefan@xxxxxxxx> >> >> Ideally this two patches should go into v4.19. Not sure which path the patch should take, MAINTAINERS is not quite clear about that. This fixes 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually exclusive") for ARM32, which has been merged directly by >> Linus, afaict... > > Good point, can you resend these to me with all of the acks added so > far? Sure (I think only Stefan is the added ack, though). Cheers, Miguel
