On Thu, Aug 30, 2018 at 01:02:44AM +0100, Ramsay Jones wrote: > > > On 29/08/18 22:57, Luc Van Oostenryck wrote: > > On Wed, Aug 29, 2018 at 03:55:20AM +0100, Ramsay Jones wrote: > >> Hi Luc, > >> > >> Just a quick note about the recent SSA commits on your sparse.git > >> master branch (commits d46b7b2..96f388f). I haven't looked at them > >> in detail, but they cause the 'make selfcheck' target to complain: > > > > I've spend months on testing and retesting it but I forgot to > > use selfcheck! I'm even more surprise that I haven't include > > ssa.h in ssa.c ... :( > > > >> The patch below fixes up the warnings. I assume the idf_dump() function > >> is useful to have around to debug the dominance frontier while in the > >> debugger (making it static would cause gcc to complain). > > > > It was certainly useful at the beginning, now much less but who > > knows it can still one day. ... > > Thank you for looking at this. > > I would like to apply your patch but you haven't added your signoff. > > May I add it? > > Well, it wasn't really a patch; I had anticipated that you > would squash the hunks into the relevant commits (hence the > comment). Yes, it is generally not a good idea to re-wind > a published branch to make such changes, but that kinda > depends on how many people will be affected ... I probably should have reposted this series but since had changed I didn't. > However, if you would rather not rewind the branch and want to > apply the 'patch' on top, then that is fine by me as well, so: > > Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> Yes, I don't want to rewind since it's now published. Thank you. -- Luc
