On 26/08/18 08:43, Luc Van Oostenryck wrote: > On Sun, Aug 26, 2018 at 12:37:53AM +0100, Ramsay Jones wrote: >> On 25/08/18 23:44, Luc Van Oostenryck wrote: >>> On Sat, Aug 25, 2018 at 10:11:57PM +0100, Ramsay Jones wrote: >>>> >>>> >>>> On 25/08/18 16:43, Luc Van Oostenryck wrote: >>>>> Opcodes are defined in linearize.c:enum opcode. >>>>> The file opcode.c also contains a table with opcodes properties. >>>>> >>>>> Centralize these definitions into a single file: opcode.def that >>>> >>>> opcode.def? Hmm, I think opcode-def.h may be better. >>> >>> Well, it's not a header file, it can't be used as one. I then prefer >> >> Heh, it is no more or less a header file as any other in the project! > > Not to me, sorry. A 'true' header file contains definition and/or > declarations enclosed with a guard protecting against multiple > inclusion and are normally included on the top of files needing them. > Also, including them even if not needed is normally harmless. > The file here is nothing of this. OK > >> The fact that the macros called in it are defined in another file is >> also not that uncommon! >> >>> to not use the .h extension for it (and using the extension .def >> >> Windows folk may get confused. ;-) > > Just because of the name or can tools be confused too? No, not unless you actually feed the file to the compiler/linker. Well, I have heard that some 'project import' tools in various IDEs can be upset, but don't quote me on that, since I don't use any such IDE (unless you count vim!). ;-) > Because the additional +/-/space character added in front of the lines > in patch format. I assure you that the file is perfectly aligned (when > using tabstops of 8). Anyway, I'm using all spaces now. Yep, my brain fade! ATB, Ramsay Jones
