On Tue, Aug 21, 2018 at 9:15 AM, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote: >> Note that there are a few definitions of BUILD_BUG_ON that still use >> this negative array size trick. Should that pattern be removed from >> them as well? See: >> * arch/x86/boot/boot.h#L33 >> * include/linux/build_bug.h#L66 >> * tools/include/linux/kernel.h#L38 > > At this moment, -Wvla is the warning-3 level > in scripts/Makefile.extrawarn. We're down to a handful of VLA uses, but I don't think the negative cases should matter since they're _intended_ to break a compile. -Kees -- Kees Cook Pixel Security