In simplify_cond_branch(), the new condition is given via a pointer but
there is no reasons to use a pointer here.
Pass the new condition directly (and use a more descriptive name for it).
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
---
simplify.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/simplify.c b/simplify.c
index be7208608..77d818e1f 100644
--- a/simplify.c
+++ b/simplify.c
@@ -1075,9 +1075,9 @@ static int simplify_range(struct instruction *insn)
/*
* Simplify "set_ne/eq $0 + br"
*/
-static int simplify_cond_branch(struct instruction *br, pseudo_t cond, struct instruction *def, pseudo_t *pp)
+static int simplify_cond_branch(struct instruction *br, pseudo_t cond, struct instruction *def, pseudo_t newcond)
{
- use_pseudo(br, *pp, &br->cond);
+ use_pseudo(br, newcond, &br->cond);
remove_usage(cond, &br->cond);
if (def->opcode == OP_SET_EQ) {
struct basic_block *tmp = br->bb_true;
@@ -1116,9 +1116,9 @@ static int simplify_branch(struct instruction *insn)
if (def->opcode == OP_SET_NE || def->opcode == OP_SET_EQ) {
if (constant(def->src1) && !def->src1->value)
- return simplify_cond_branch(insn, cond, def, &def->src2);
+ return simplify_cond_branch(insn, cond, def, def->src2);
if (constant(def->src2) && !def->src2->value)
- return simplify_cond_branch(insn, cond, def, &def->src1);
+ return simplify_cond_branch(insn, cond, def, def->src1);
}
if (def->opcode == OP_SEL) {
if (constant(def->src2) && constant(def->src3)) {
--
2.17.1
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
