On Thu, Jun 07, 2018 at 04:47:43PM -0700, Kees Cook wrote: > On Thu, Jun 7, 2018 at 4:39 PM, Luc Van Oostenryck > <luc.vanoostenryck@xxxxxxxxx> wrote: > > This series adds support for the builtins doing overflow checking: > > * __builtin_{add,sub,mul}_overflow() and the _overflow_p() variants > > * __builtin_[us]{add,sub,mul}{,l,ll}_overflow() > > since these, or at least __builtin_{add,mul}_overflow() are now used > > in the kernel. > > Oh nice! With this in place, should I not add the CHECKER test in the kernel? > > -Kees Tricky question! I find sad and counter-productive to have to add such checks. Sparse should run on the same code as the one that is compiled. It's why I added support for those builtins. But to be honest, before this appears in the official tree and in the distros most people use ... it can take some time. Note: my github tree contains numerous others fixes and improvements that are waiting to be taken in the official tree (hint hint hint). Cheers, -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html