Re: Fwd: Noisy Sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 19, 2018 at 12:13:20PM -0500, Steve French wrote:
> Looks like 0.5.2-rc1 helped with two but now am getting a new one.
> 
> I have two systems - both are now verified (sparse --version) as running
> version 0.5.2-rc1 for the user doing the build (that was part of the
> problem, it was finding sparse 0.5.0 when running as a different user than
> the one who had installed version 0.5.2-rc1)

OK, make sense.

> but I do get one error repeatedly
> on one of the two Ubuntu systems (identical, current version, of Ubuntu)
> 
>   CHECK   fs/cifs/connect.c
> fs/cifs/connect.c:825:25: warning: expression using sizeof(void)

Yes, that's something new. The patch is not yet in any release or
pre-release but you can use one of:
	git://github.com/lucvoo/sparse-dev.git sparse-0.5
	git://github.com/lucvoo/sparse.git     master

> See one of the dozen's of cases below:
> 
> cifs_dump_mem("Bad SMB: ", buf,
>                         min_t(unsigned int, server->total_read, 48));
> 
> it looks like "min_t" is causing confusion for sparse.

Sparse used to warn when using 'sizeof(void)' since it's totally non-standard
and there was only a very few such uses in the kernel. But a recent change
in min/max changed that and now there is a lot of such warnings. Those
warnings are now disabled by the patch in the trees here above.

Cheers,
-- Luc
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux