On Thu, Feb 22, 2018 at 04:02:20AM +0100, Jann Horn wrote: > On Thu, Feb 22, 2018 at 3:49 AM, Luc Van Oostenryck > <luc.vanoostenryck@xxxxxxxxx> wrote: > > On Thu, Feb 22, 2018 at 02:11:44AM +0100, Jann Horn wrote: > >> If you dereference a function pointer, you get a function pointer back. > >> AFAICS there are >=69 places in the kernel that unnecessarily dereference a > >> function pointer before calling through it. > > > > Hi, > > > > Yes. This is in fact a known problem. > > A fix for it and some others related to problems with > > dereferences, as well as a bunch of test cases, can be > > found in my development tree: > > https://github.com/lucvoo/sparse-dev/tree/master > > > > The patches related to this issues are the ones just before > > commit 1e1a172fe. > > Ah, I see. > https://github.com/lucvoo/sparse-dev/commit/eeacb2cb90b2a6275935bb61613383413a9d2779 > and > https://github.com/lucvoo/sparse-dev/commit/2be50b1451d954b4ea4579bcb7173e57d8a07161 > . Thanks for pointing me to those! > > Are there more trees that would be helpful to know about? I assumed > that the master branch of > https://git.kernel.org/pub/scm/devel/sparse/sparse.git/ would be a > reasonable place to start development from, but apparently that's not > true, given that you have three months' worth of patches in your tree? I don't think so. I have the tree (which I would have used here above) https://github.com/lucvoo/sparse which is a stable tree (well tested and never rebased) containing my patches and the few other patches sent to the mailing list. The branch point with the official tree is indeed a few months ago. My other tree is at: https://github.com/lucvoo/sparse-dev and it's a non-stable development tree (topics branches are not finam, and may be rebased, 'tip' is a quasi stable branch I use to aggregate topic branches and is sometimes rebased, 'master' is the same as the stable tree). -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
