On Wed, Jan 24, 2018 at 08:19:23PM +0100, Luc Van Oostenryck wrote: > On Wed, Jan 24, 2018 at 09:48:07AM -0800, Randy Dunlap wrote: > > On 01/24/2018 12:28 AM, Luc Van Oostenryck wrote: > > > On Mon, Jan 22, 2018 at 11:05:09AM -0800, Randy Dunlap wrote: > > >> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > >> > > >> In error(), quiet is undefined when the command: > > >> $ ./test-suite format filename1.c foobar1 > > >> > > >> is used and filename1.c does not exist. This causes a shell script error: > > >> ./test-suite: line 147: [: : integer expression expected > > >> > > >> because $quiet is undefined in > > >> [ "$quiet" -ne 1 ] && echo "error: $1" > > >> so the error message is lost. > > >> > > >> Just initialize quiet before any command line parsing. > > >> > > >> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > > > > > cfr: https://marc.info/?l=linux-sparse&m=151273892009415 > > > > I don't think that will fix the original problem that I posted the > > patch for. > > Yes, you're right. > The original problem doesn't exist in my tree but for another reason. Nevertheless, the reason explained in my patch is still valid and $quiet also need to be reset early in do_test(). -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
