Re: [PATCH] test-suite: handle format with filename.c not existing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 23, 2018 at 10:20 AM, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> I guess that I don't understand the interplay between $V and $quiet and why
> have both of them.
>

It seems that $quiet is just invert of $V, which introduce in
the following two commits by Luc.

commit: ee43fc784e52e3ee9e1b45da1be5193ea3b64334
Author: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
Date:   Mon Feb 13 00:29:04 2017 +0100

    testsuite: quieter error reporting for 'known-to-fail'

commit: d2a7009a78effb2a8ac867de9240c4a89d181f5d
Author: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
Date:   Mon Feb 13 00:29:03 2017 +0100

    testsuite: allow quieter error reporting


> Are you suggesting that $quiet should be initialized by default like this:
> (just drop the $must_fail part)
>
>> quiet=0
>> [ $V -eq 0 ] && quiet=1


yes, I was thinking some thing like this,
but I haven't give it a lot of test.

>diff --git a/validation/test-suite b/validation/test-suite
index cf151a3..5e10942 100755
--- a/validation/test-suite
+++ b/validation/test-suite
@@ -31,6 +31,7 @@ known_ko_tests=0

 # defaults to not verbose
 [ -z "$V" ] && V=0
+[ $V -eq 0 ] && quiet=1 || quiet=0

 ##

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux