Re: [PATCH v2] add __builtin functions for isinf_sign, isfinite and isnan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 17, 2017 at 7:08 AM, Logan Gunthorpe <logang@xxxxxxxxxxxx> wrote:
> These bultins are defined by in gcc since 4.4. They are also now
> used by the isinf, isfinite and isnan macros. So using them with a
> newer gcc causes 'undefined identifier' errors.
>
> Add the builtin definitions and some validation checks for these
> functions.
>

Thanks, applied and push to master.

>
> Changes since v1:
>  * Remove math.h dependancy from validation tests. As a consequnce
>    we don't test that the math functions work. (Per a request from
>    Christopher.)

Just to clarify. The "make check" is a quick smoke test for sparse to
expose regression etc. It does not mean to be a complete system test.
It is more like a test to be run on before every commit.

In the history we are having header file issue with cygwin and other compile
environment due to sparse don't understand other system macros. It is
better to have sparse able to run the validations test without have to fix
every single system macro define. It is kind of expect to be broken on new
and untested platform. There for, best to have no system header in the
validation test.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux