Hello Luc, On 11/06/2017 04:43 PM, Luc Van Oostenryck wrote: > On Mon, Nov 06, 2017 at 09:57:23AM +0100, Uwe Kleine-König wrote: >>> -local.mk >>> +.sparse.mk >> >> what is the motivation to hide this file? IMHO it is better to be aware >> of eventual changes to the build system and so don't hide the file. >> >> Having said that I question if it is a good idea at all to provide a way >> to change the build without dirtying the working copy. > > I confess that this change is just for my own confort. > I often need to change change the CFLAGS while debugging or profiling. > I want that to be in a file, the file must of course not be under > version control and like .bashrc, kernel's .config or GCC's generated > .*.o.d files, I don't need to see this file and so I prefer it's an > hidden one. > > I understand your worries but since it's a file purposely changed > so that files are compiled differently, there is no surprises. <sarcasm> We could also add #include ".sparse.c" at the end of sparse.c (and touch this file in Makefile) in case you want to add a function there without dirtying the working copy. This could be used to overwrite weak functions for example. Oh, and given that order in Makefile sometimes matter, we could add an sinclude sparse-pre.mk at the start of Makefile. </sarcasm> IMHO these suggestions (that I hope you find absurd, too) are only little worse than your justification above. If I'd want to change CFLAGS, I'd do that directly in Makefile. git is powerful enough that this isn't in the way of committing and I personally like being remembered that I changed something. Of course this is subjective. > For dirtying the build ... yes, something could be done but really, > personnaly, I don't need this, I know when I need to clean my tree famous words. How often did it happen to you that you thought you'd remember stuff when you need it and then only managed to do this after a 2 hour long debug session? Best regards Uwe
Attachment:
signature.asc
Description: OpenPGP digital signature
