On Thu, Nov 9, 2017 at 7:03 PM, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: > > > On 09/11/17 17:55, Ramsay Jones wrote: >> >> >> On 09/11/17 17:43, Luc Van Oostenryck wrote: >>> On Thu, Nov 9, 2017 at 6:37 PM, Ramsay Jones >>> <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: >>>> >>>> >>>> On 09/11/17 17:06, Luc Van Oostenryck wrote: >>>>> >>>>> Acked-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> >>>>> >>>>> >>>>> BTW, selfcheck also fails when reaching sparse-llvm.c because of >>>>> the use of CFLAGS/BASIC_CFLAGS/ALL_CFLAGS/COMMON_CFLAGS/PKG_CFLAGS. >>>> >>>> Hmm, I used to have LLVM installed on Linux as well as cygwin, but >>>> I didn't install it the last time I did a 'nuke-n-pave' Linux >>>> installation. (Linux Mint is much easier to upgrade these days, which >>>> is to say it actually works now, but that wasn't always the case!). >>>> >>>> On cygwin, sparse-llvm.c complains for a cygwin-only reason, so it >>>> may be that those errors a hiding the ones you are seeing. I have been >>>> meaning to get around to fix the cygwin problems. >>>> >>>> What kind of errors are you seeing? >>> >>> The specific error message is: >>> sparse-llvm.c:6:11: error: unable to open 'llvm-c/Core.h' >>> but the cause is simply because the LLVM CFLAGS are used like: >>> sparse-llvm.o: BASIC_CFLAGS += $(LLVM_CFLAGS) >>> but selfcheck/cgcc, correctly, doesn't know about BASIC_CFLAGS. >> >> Hmm, that doesn't make much sense - the selfcheck target uses >> the $(ALL_CFLAGS), just like the '%.o %.c' target. So, if the >> file is compiled by gcc, then cgcc should have the same flags >> (plus some sparse specific flags). >> >> [This is the Makefile on the master branch @ c408da2]. >> >> puzzled ... > > Ah, no longer puzzled. Hmm, didn't there used to be a rule like: > > sparse-llvm.o sparse-llvm.sc: BASIC_CFLAGS += $(LLVM_CFLAGS) > > this? Yes, for example. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
