Re: [PATCH] volatile loads are side-effects too

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 08, 2017 at 02:55:05AM +0800, Christopher Li wrote:
> On Tue, Nov 7, 2017 at 11:59 PM, Luc Van Oostenryck
> <luc.vanoostenryck@xxxxxxxxx> wrote:
> > Some branch simplifications are only valid if the branch is free
> > of side-effects. The check is done in flow.c:bb_has_side_effects()
> > but currently deosn't take in account the fact that a volatile load
> > is also a side-effect.
> >
> > Fix this by adding the appropriate check.
> >
> > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
> 
> Looks good to me.

Thank you for the review.
Thank you for the very fast review.

-- Luc
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux