Re: [PATCH 21/36] build: no need to clean *.so and SLIB_FILE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 05, 2017 at 09:48:07AM -0800, Josh Triplett wrote:
> On Sun, Nov 05, 2017 at 05:25:29PM +0100, Luc Van Oostenryck wrote:
> > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
> > ---
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index a8578c305..23c334132 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -207,7 +207,7 @@ version.h: FORCE
> >  
> >  
> >  clean: clean-check
> > -	rm -f *.[oa] .*.d *.so $(PROGRAMS) $(SLIB_FILE) version.h
> > +	rm -f *.[oa] .*.d $(PROGRAMS) $(SLIB_FILE) version.h
> 
> You didn't remove SLIB_FILE here. And also, this should get squashed
> into the patch that stops building these.

I know, this patch only remove the '*.so' which was redundant with
$(SLIB_FILE).
This was before I decided to remove everything related to shared lib.

And yes, once shared are removed, it's simpler to remove everything
at the same time. I'll do that in next version.

Thanks for the review,
-- Luc
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux