Re: [PATCH 01/36] build: make PREFIX overwritable from the environment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Josh,

On 11/05/2017 06:44 PM, Josh Triplett wrote:
> On Sun, Nov 05, 2017 at 05:25:09PM +0100, Luc Van Oostenryck wrote:
>> From: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>
>>
>> This way I can just use
>>
>> 	env PREFIX=/usr make install
>>
>> on the command line to install sparse into the system.
> 
> You can already use "make PREFIX=/usr install" to do this, which seems
> far more conventional, and seems less error-prone (e.g. it won't pick up
> something random from the environment, only something intentionally put
> on the command line).

Having PREFIX in the build environment and then being surprised that
it's picked up by a build isn't something I'd show consideration for.

> Any particular reason to do this?

I had this patch in my stack for the sparse debian package because
with debhelper it is easier to put something into the environment than
to overwrite the make command line. (But having said that, the currently
used packaging doesn't rely on this feature any more.)

Best regards
Uwe

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux