Re: [PATCH] build: assign extra flags to ALL_CFLAGS instead of CFLAGS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2017-10-18 at 21:41 +0200, Luc Van Oostenryck wrote:
> On Wed, Oct 18, 2017 at 5:12 PM, Jeff Layton <jlayton@xxxxxxxxxxxxxxx> wrote:
> > 
> >     The fedora packaging tools want to override $CFLAGS when building
> >     sparse, but that fails on a couple of targets.
> > 
> >     There are a couple of build targets in the makefile that want to add
> >     options to $CFLAGS. When we do a build though, we pass $ALL_CFLAGS to
> >     the compiler, and that ends up without those extra options, if CFLAGS=
> >     was specified on the command line.
> > 
> >     I'm not sure if this is a recursive variable expansion bug in make, but
> 
> I think it's just an effect of CFLAGS being then used as a
> target-specific variable
> 
> -- Luc

Ahh ok...so this is probably the correct fix then?

Thanks for looking!
-- 
Jeff Layton <jlayton@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux