Re: [PATCH] fix cgcc ELF version for ppc64/pcc64le

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Luc,

On Wed, Sep 27, 2017 at 11:11:37PM +0200, Luc Van Oostenryck wrote:
> Commit e0306fe0 "cgcc: teach cgcc about ppc64[le]" add support
> for PPC64 to cgcc by adding the needed options like '-m64' &
> '-m{little,big}-endian' and defines likes '-D__PPC64__=1'.
> 
> In this commit the defined '-D_CALL_ELF=2' was also added
> but the value of 2 is for ELF v2 ABI, normally used for ppc64le,
> while the older ELF ABI, normally used for plain ppc64 should use
> '-D_CALL_ELF=2'.
> 
> Fix this by using the value of 1 or 2 for '_CALL_ELF' depending
> if the architecture is ppc64 or ppc64le.
> 
> Fixes: e0306fe0b725af6e2e7ff59d7f0d99c96315791a
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>

I tested that patch on the following machines:

hostname/chroot                 uname -m        gcc -dumpmachine
partch/sid                      ppc             powerpc-linux-gnu
pizzetti/sid_ppc64-dchroot      ppc64           powerpc64-linux-gnu
plummer/sid_ppc64el-dchroot     ppc64le         powerpc64le-linux-gnu

and my test case (env CHECK=./sparse ./cgcc -no-compile memops.c) works
on all of them now.

Tested-by: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>

Thanks
Uwe

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux